[U-Boot] universal_c210: fix compiler error and compiler warning

Piotr Wilczek p.wilczek at samsung.com
Mon Dec 10 11:28:39 CET 2012


On 12/10/2012 07:50 AM, Minkyu Kang wrote:
> This patch fix following errors
>
> universal.c: In function 'init_pmic_lcd':
> universal.c:340: warning: implicit declaration of function 'get_pmic'
> universal.c:340: warning: initialization makes pointer from integer without a cast
> universal.c: In function 'lcd_power_on':
> universal.c:431: warning: initialization makes pointer from integer without a cast
> universal.c: At top level:
> universal.c:335: warning: 'init_pmic_lcd' defined but not used
>
> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
> Cc: Donghwa Lee <dh09.lee at samsung.com>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> ---
>   board/samsung/universal_c210/universal.c |    8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
> index 3d508be..4869798 100644
> --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -55,6 +55,8 @@ static int get_hwrev(void)
>   	return board_rev & 0xFF;
>   }
>
> +static void init_pmic_lcd(void);
> +
>   int power_init_board(void)
>   {
>   	int ret;
> @@ -63,6 +65,8 @@ int power_init_board(void)
>   	if (ret)
>   		return ret;
>
> +	init_pmic_lcd();
> +
>   	return 0;
>   }
>
> @@ -337,7 +341,7 @@ static void init_pmic_lcd(void)
>   	unsigned char val;
>   	int ret = 0;
>
> -	struct pmic *p = get_pmic();
> +	struct pmic *p = pmic_get("MAX8998_PMIC");
>
>   	if (pmic_probe(p))
>   		return;
> @@ -428,7 +432,7 @@ static void reset_lcd(void)
>
>   static void lcd_power_on(void)
>   {
> -	struct pmic *p = get_pmic();
> +	struct pmic *p = pmic_get("MAX8998_PMIC");
>
>   	if (pmic_probe(p))
>   		return;
>
Tested-by: Piotr Wilczek <p.wilczek at samsung.com>




More information about the U-Boot mailing list