[U-Boot] [PATCH v2] m28evk/mx28evk: fix nand_update_full

Marek Vasut marex at denx.de
Wed Dec 12 04:05:06 CET 2012


Dear Scott Wood,

> On 12/11/2012 03:36:21 PM, Eric Bénard wrote:
> > - since commit 418396e212b59bf907dbccad997ff50f7eb61b16 nand write.raw
> > can take the number of page to be written as an argument.
> > nand_update_full
> > is passing the size (in bytes) to nand write.raw. This value was
> > previously
> > ignored but now breaks the write.
> > - this patch updates the default environment of these boards to
> > provide a
> > pagecount instead of a size to nand write.raw.
> > - tested on a mx28evk with a 4k page NAND and on a custom board with a
> > 2k page NAND.
> > 
> > Signed-off-by: Eric Bénard <eric at eukrea.com>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > ---
> > 
> >  include/configs/m28evk.h  |    2 +-
> >  include/configs/mx28evk.h |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Marek, can you ack this?
> 
> There is still a change in behavior in that before
> 418396e212b59bf907dbccad997ff50f7eb61b16 it only wrote one page (since
> that's all the write.raw command ever did) but with this patch it will
> write ${fcb_sz} pages.  I assume the new behavior is correct?

Yes, it's correct

Acked-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list