[U-Boot] [PATCH resend 2/2] net/macb: Add arch specific routine to get mdio control

[Stefan Roese]

On 12/06/2012 08:10 AM, Vipin Kumar wrote:
> From: Shiraz Hashim <shiraz.hashim at st.com>
> 
> SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their
> respective phys. Currently their is a fixed configuration in which only a
> particular MAC can use the MDIO lines.

"there is" instead of "their is"

> Call an arch specific function to take control of specific mdio lines at
> runtime.
> 
> Signed-off-by: Shiraz Hashim <shiraz.hashim at st.com>
> Signed-off-by: Vipin Kumar <vipin.kumar at st.com>
> ---
>  drivers/net/macb.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 8bacbda..45fbbd7 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -163,6 +163,13 @@ static u16 macb_mdio_read(struct macb_device *macb, u8 reg)
>  	return MACB_BFEXT(DATA, frame);
>  }
>  
> +static void __def_arch_get_mdio_control(const char *name)
> +{
> +	return;
> +}
> +int arch_get_mdio_control(const char *name)
> +	__attribute__((weak, alias("__def_arch_get_mdio_control")));

__weak from linux/compiler.h please

Otherwise:

Acked-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan