[U-Boot] [PATCH resend] spi/arm-pl022: Add support for ARM PL022 spi controller

[Stefan Roese]

On 12/12/2012 12:10 PM, Armando Visconti wrote:
>>>> +
>>>> +/* SSP registers mapping */
>>>> +#define SSP_CR0		0x000
>>>> +#define SSP_CR1		0x004
>>>> +#define SSP_DR		0x008
>>>> +#define SSP_SR		0x00C
>>>> +#define SSP_CPSR	0x010
>>>> +#define SSP_IMSC	0x014
>>>> +#define SSP_RIS		0x018
>>>> +#define SSP_MIS		0x01C
>>>> +#define SSP_ICR		0x020
>>>> +#define SSP_DMACR	0x024
>>>> +#define SSP_ITCR	0x080
>>>> +#define SSP_ITIP	0x084
>>>> +#define SSP_ITOP	0x088
>>>> +#define SSP_TDR		0x08C
>>>
>>> Please use C-structs instead to access the registers.
>>>
>>
>> May be this patch is a ripped version from linux. That's why
>> Thanks. I will do this in v2
>>
> 
> Yes,
> I took this part from the linux pl022 driver.
> 
> Never understood which way (C-struct or defines) is preferable
> and why...

U-Boot is here more strict than Linux here. Using C-struct's enables
type-checking. So thats the preferred way.

Thanks,
Stefan