[U-Boot] [PATCH V3 1/7] Tegra30: Add arch-tegra30 include files

Tom Warren twarren.nvidia at gmail.com
Wed Dec 12 17:23:39 CET 2012


Stephen,

On Tue, Dec 11, 2012 at 5:36 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 12/11/2012 04:34 PM, Tom Warren wrote:
>> Common Tegra files are in arch-tegra, shared between T20 and T30.
>> Tegra30-specific headers are in arch-tegra30. Note that some of
>> these will be filled in as more T30 support is added (drivers,
>> WB/LP0 support, etc.). A couple of Tegra20 files were changed
>> to support common headers in arch-tegra, also.
>
>> diff --git a/arch/arm/include/asm/arch-tegra/tegra.h b/arch/arm/include/asm/arch-tegra/tegra.h
>
>> +     TEGRA_SOC2_SLOW,        /* T2x needs to run at slow clock initially */
>
> I don't think that's used anywhere; drop it?

This is a series to add T30 support. I've done some changes to
combine/commonize shared files, etc., but I've tried to avoid any
T20-only changes whenever possible.

I'll add this as a note in my to-do cleanup patch list for T20.

>
>> -     TEGRA_SOC_COUNT,
>> +     TEGRA_SOC_CNT,
>
> A little arbitrary, but whatever.

Not arbitrary, I needed to keep the tegra_pll_x_table declaration in
common/cpu.c below 80 chars, and didn't like the look of it anywhere I
split it, so I decided to shrink this label a bit since it was only
used in that one place and would have the least impact.

>
> Aside from that, this patch,
> Reviewed-by: Stephen Warren <swarren at nvidia.com>

Thanks,

Tom


More information about the U-Boot mailing list