[U-Boot] [PATCH v2] imls: Add support to list images in NAND device

[Wolfgang Denk]

Dear Vipin Kumar,

In message <dba14c4ffef38a108f75342968bcd9ce2b75c4c7.1355303894.git.vipin.kumar at st.com> you wrote:
> imls does not list the images in NAND devices. This patch implements this
> support for legacy type images.
...
> -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +static void do_imls_flash(void)

Why is this void?  Should we not return error codes? Or at least be
able to?

> +static void do_imls_nand(void)

Ditto.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Far back in the mists of ancient time, in the great and glorious days
of the former Galactic Empire, life was wild, rich  and  largely  tax
free.         - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_