[U-Boot] [PATCH V3 4/7] Tegra30: Add common CPU (shared) files

[Stephen Warren]

On 12/12/2012 09:14 AM, Tom Warren wrote:
> Allen,
> 
> On Tue, Dec 11, 2012 at 5:45 PM, Allen Martin <amartin at nvidia.com> wrote:
>> On Tue, Dec 11, 2012 at 03:34:15PM -0800, Tom Warren wrote:
>>> These files are used by both SPL and main U-Boot.
>>> Also made minor changes to shared Tegra code to support
>>> T30 differences.
>>>
>>> Signed-off-by: Tom Warren <twarren at nvidia.com>
>>> ---
>>> V2:
>>> * Differentiate between T20 and T30 in ODMDATA and query_sdram_size.
>>> * Fix numerous func entries in pingroup table as per Stephen.
>>> * Added warning about LOCK bit in pinmux_set_lock.
>>> V3:
>>> * Always program PLLP to 408MHz
>>> * Use generic SoC string in print_cpuinfo
>>>
> <snip>
>>>
>>> -       bct_start = readl(AP20_BASE_PA_SRAM + NVBOOTINFOTABLE_BCTPTR);
>>> +       bct_start = readl(NV_PA_BASE_SRAM + NVBOOTINFOTABLE_BCTPTR);
>>>         odmdata = readl(bct_start + BCT_ODMDATA_OFFSET);
>>>
>>>         return odmdata;
>>> @@ -127,5 +137,5 @@ void s_init(void)
>>>                 "orr    r0, r0, #0x41\n"
>>>                 "mcr    p15, 0, r0, c1, c0, 1\n");
>>>
>>> -       /* FIXME: should have ap20's L2 disabled too? */
>>> +       /* FIXME: should have SoC's L2 disabled too? */
>>
>> We should probably just remove this README, I don't believe it applies
>> any more.
> 
> By README, you mean FIXME? It can be removed, but only if I'm forced
> to do a V4 patchset for more substantive changes. Otherwise I'll put
> it in my list of 'cleanup' items.

In my opinion at least, for very minor stuff like this, you can just
implement the review feedback and apply the patches without the need to
actually repost it. Anything much more than editing a comment, removing
a stale comment or removing some added lines from the patch that
shouldn't be added would warrant a repost though.