[U-Boot] [PATCH V3 1/7] Tegra30: Add arch-tegra30 include files

Tom Warren twarren.nvidia at gmail.com
Thu Dec 13 00:06:23 CET 2012


Stephen,

On Wed, Dec 12, 2012 at 3:02 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 12/12/2012 09:23 AM, Tom Warren wrote:
>> Stephen,
>>
>> On Tue, Dec 11, 2012 at 5:36 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>> On 12/11/2012 04:34 PM, Tom Warren wrote:
>>>> Common Tegra files are in arch-tegra, shared between T20 and T30.
>>>> Tegra30-specific headers are in arch-tegra30. Note that some of
>>>> these will be filled in as more T30 support is added (drivers,
>>>> WB/LP0 support, etc.). A couple of Tegra20 files were changed
>>>> to support common headers in arch-tegra, also.
>>>
>>>> diff --git a/arch/arm/include/asm/arch-tegra/tegra.h b/arch/arm/include/asm/arch-tegra/tegra.h
>>>
>>>> +     TEGRA_SOC2_SLOW,        /* T2x needs to run at slow clock initially */
>>>
>>> I don't think that's used anywhere; drop it?
>>
>> This is a series to add T30 support. I've done some changes to
>> combine/commonize shared files, etc., but I've tried to avoid any
>> T20-only changes whenever possible.
>>
>> I'll add this as a note in my to-do cleanup patch list for T20.
>
> My point here was that this patch adds that unused enum. I think you can
> just drop the addition from the patch, and it'll never need to be
> cleaned up?
>
OK, good point. I had thought TEGRA_SOC2_SLOW was there originally in
the Tegra20 codebase, but you are right - it looks like I brought it
in, probably from our internal repo. I'll drop it. Thanks.


More information about the U-Boot mailing list