[U-Boot] [PATCH resend 2/2] arm/boards: Define a new config option CONFIG_BOOT_PARAMS_P

Vipin Kumar vipin.kumar at st.com
Mon Dec 17 09:15:00 CET 2012


On 12/7/2012 8:17 PM, Wolfgang Denk wrote:
> Dear Vipin Kumar,
>
> In message<50C1B9A6.1020106 at st.com>  you wrote:
>>
>> Can you please suggest what is the best way here. Wolfgang, Albert ?
>
> I don't like this patch at all.   It introduces yet more
> architecture specific stuff to lib/board.c, while we actually should
> be working on coming up with a common version for all architectures.
>
> If you want to simplify code, then please not by making it worse in
> other places.
>

I agree, but this code adds an option to pass boot params pointer to 
board descriptor.
Just two lines above the intended change, there is a mach_type 
initialization based on the definition of CONFIG_MACH_TYPE. Moreover, 
the lib/board.c exists in arch/arm as of today which means that it can 
contain all the stuff common for arm boards

If I am right, the patch should also be OK

Vipin

> Best regards,
>
> Wolfgang Denk
>



More information about the U-Boot mailing list