[U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

Tom Rini trini at ti.com
Mon Dec 17 18:45:36 CET 2012


On Mon, Dec 17, 2012 at 12:37 PM, Lukasz Majewski
<l.majewski at samsung.com> wrote:
> Hi Tom,
>
>> On Wed, Nov 28, 2012 at 03:47:43PM +0100, Lukasz Majewski wrote:
>>
>> > Hi Pantelis,
>> >
>> > > USB initialization shouldn't happen for all the boards.
>> > >
>> >
>> > The board_usb_init() follows u-boot policy, that SoC IPs (USB) are
>> > enabled and configured just before their usage.
>>
>> Going back to this old thread as I dig at things again.  How much of
>> s3c_udc_probe is actually enabling hardware as opposed to registering
>> that such hardware exists and can be enabled when we call
>> usb_gadget_register_driver ?  It looks like all of the clocking (and
>> pin muxing?) is already being done.
>>
>
> I will check if s3c_udc_probe can be removed totally and replaced by
> usb_gadget_register_driver (since some time has passed from original
> UDC driver posting).

Well, not so much replace but just, if there's no actual HW init, move
the "probe" (which isn't a probe, it's registering board infos) call
into arch_misc_init or similar.

--
Tom


More information about the U-Boot mailing list