[U-Boot] [U-Boot, v2 2/6] cmd_sf: Add print messages on flash read/write commands

Jagan Teki jagannadh.teki at gmail.com
Thu Dec 20 08:49:05 CET 2012


Hi Wolfgang Denk,

On Thu, Dec 20, 2012 at 4:48 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Jagannadha Sutradharudu Teki,
>
> In message <1355934463-24319-2-git-send-email-jagannadh.teki at gmail.com> you wrote:
>> This patch adds a print messages while using 'sf read' and
>> 'sf write' commands to make sure that how many bytes read/written
>> from/into flash device.
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com>
>> ---
>> Changes in v2:
>>         Move print messages from spi_flash.c into cmd_sf.c
>
> Please see previous comments, especially
>
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149663
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149665
>
> I object against adding more and more verbosity and code size, and in
> an inconsistent way.

Please see my comments on previous patch.
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/149698

Thanks,
Jagan.

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> F u cn rd ths u cnt spl wrth a dm!


More information about the U-Boot mailing list