[U-Boot] [PATCH] mx53loco: Fix PMIC name

[Robert Nelson]

On Tue, Dec 11, 2012 at 10:36 AM, Fabio Estevam
<fabio.estevam at freescale.com> wrote:
> commit c73368150 (pmic: Extend PMIC framework to support multiple instances
> of PMIC devices) has incorrectly passed the PMIC name under the FSL PMIC case.
>
> Fix that by passing "FSL_PMIC" as the parameter of pmic_get.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  board/freescale/mx53loco/mx53loco.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
> index 81c511c..2c8cb7a 100644
> --- a/board/freescale/mx53loco/mx53loco.c
> +++ b/board/freescale/mx53loco/mx53loco.c
> @@ -374,7 +374,7 @@ static int power_init(void)
>                 if (retval)
>                         return retval;
>
> -               p = pmic_get("DIALOG_PMIC");
> +               p = pmic_get("FSL_PMIC");
>                 if (!p)
>                         return -ENODEV;
>
> --
> 1.7.9.5

Hi Fabio,

It looks like we need one more fixup after commit c73368150 on the
first run/older (non R, Dialog, bug wired extra Capacitor) version of
this board..  Do you happen to have any in your lab?

U-Boot 2013.01-rc2-dirty (Dec 20 2012 - 15:55:01)

Board: MX53 LOCO
I2C:   ready
DRAM:  1 GiB
pmic_alloc: No available memory for allocation!
pmic_init: POWER allocation error!
CPU:   Freescale i.MX53 family rev2.0 at 800 MHz
Reset cause: POR
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
*** Warning - bad CRC, using default environment

(and it just keeps on resetting)

It looks to be failing after calloc...
http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/power/power_core.c#l100

 100         p = calloc(sizeof(*p), 1);
 101         if (!p) {
 102                 printf("%s: No available memory for
allocation!\n", __func__);
 103                 return NULL;
 104         }

Regards,

-- 
Robert Nelson
http://www.rcn-ee.com/