[U-Boot] [PATCH V4 4/4] EXYNOS5: Add support for FIMD and DP

[Minkyu Kang]

Dear Rajeshwari,

On 21/12/12 20:47, Rajeshwari Birje wrote:
> Hi Ajay
> 
> On Fri, Dec 21, 2012 at 4:05 PM, Ajay Kumar <ajaykumar.rs at samsung.com>wrote:
> 
>> Add panel_info structure required by LCD driver
>> and DP panel platdata for SMDK5250.
>> Add GPIO configuration for LCD.
>> Enable FIMD and DP support on SMDK5250.
>> DP Panel size: 2560x1600.
>> We use 16BPP resolution to get LCD console.
>>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
>> Acked-by: Simon Glass <sjg at chomium.org>
>> ---
>>  board/samsung/smdk5250/smdk5250.c |   97
>> +++++++++++++++++++++++++++++++++++++
>>  include/configs/smdk5250.h        |    8 +++
>>  2 files changed, 105 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/samsung/smdk5250/smdk5250.c
>> b/board/samsung/smdk5250/smdk5250.c
>> index 4c50342..46fd2a5 100644
>> --- a/board/samsung/smdk5250/smdk5250.c
>> +++ b/board/samsung/smdk5250/smdk5250.c
>> @@ -24,12 +24,15 @@
>>  #include <asm/io.h>
>>  #include <i2c.h>
>>  #include <netdev.h>
>> +#include <lcd.h>
>>  #include <spi.h>
>>  #include <asm/arch/cpu.h>
>>  #include <asm/arch/gpio.h>
>>  #include <asm/arch/mmc.h>
>> +#include <asm/arch/power.h>
>>  #include <asm/arch/pinmux.h>
>>  #include <asm/arch/sromc.h>
>> +#include <asm/arch/dp_info.h>
>>  #include <pmic.h>
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>> @@ -181,6 +184,100 @@ static int board_uart_init(void)
>>         return 0;
>>  }
>>
>> +void cfg_lcd_gpio(void)
>> +{
>> +       struct exynos5_gpio_part1 *gpio1 =
>> +               (struct exynos5_gpio_part1 *)
>> samsung_get_base_gpio_part1();
>> +
>> +       /* For Backlight */
>> +       s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
>> +       s5p_gpio_set_value(&gpio1->b2, 0, 1);
>> +
>> +       /* LCD power on */
>> +       s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
>> +       s5p_gpio_set_value(&gpio1->x1, 5, 1);
>> +
>> +       /* Set Hotplug detect for DP */
>> +       s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
>> +}
>>
> Cant this GPIO changes go to pinmux  file?
> 

No. It is a board specific feature.
So, can't be located in pinmux file.

Thanks.
Minkyu Kang.