[U-Boot] [PATCH v2 1/1] OMAP3: add boot status GPIO LED for IGEP boards

Javier Martinez Canillas javier at dowhile0.org
Mon Dec 24 12:51:19 CET 2012


On Mon, Dec 24, 2012 at 1:39 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Javier Martinez Canillas,
>

Hello Wolfgang,

Thanks a lot for your feedback.

> In message <1356265899-18669-1-git-send-email-javier.martinez at collabora.co.uk> you wrote:
>> This patch adds an GPIO LED boot status for IGEP boards.
>>
>> The GPIO LED used is the red LED0 while the Linux kernel
>> uses the green LED0 as the boot status.
>>
>> By using different GPIO LEDs, the user can know in which
>> step of the boot process the board currently is.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
>
> Do we really need yet another implementation of boot status
> signalling?  I think no.
>
> Please implement this a board specific version of the
> show_boot_progress() feature (see CONFIG_SHOW_BOOT_PROGRESS).
>

ok, I wasn't aware of the CONFIG_SHOW_BOOT_PROGRESS infrastructure and
thought that CONFIG_STATUS_LED was the way to go.

> Thanks - and sorry, but NAK for this implementation.
>

ok, I'll send a v3 using show_boot_progress().

> Best regards,
>
> Wolfgang Denk
>

Thanks a lot and merry christmas!
Javier


More information about the U-Boot mailing list