[U-Boot] [PATCH 1/9] mx28evk: We shouldn't hardcode a rootfs filesystem type

[Otavio Salvador]

On Wed, Dec 26, 2012 at 9:02 AM, Stefano Babic <sbabic at denx.de> wrote:
> On 21/12/2012 17:59, Otavio Salvador wrote:
>> For a generic environment, we shouldn't have a fixed rootfs filesystem
>> so we drop it from env.
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>
> Hi Otavio,
>
>>  include/configs/mx28evk.h |    7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
>> index 8b89b25..3cc0726 100644
>> --- a/include/configs/mx28evk.h
>> +++ b/include/configs/mx28evk.h
>> @@ -292,11 +292,8 @@
>>       "console_mainline=ttyAMA0\0" \
>>       "mmcdev=0\0" \
>>       "mmcpart=2\0" \
>> -     "mmcroot=/dev/mmcblk0p3 rw\0" \
>> -     "mmcrootfstype=ext3 rootwait\0" \
>> -     "mmcargs=setenv bootargs console=${console_mainline},${baudrate} " \
>> -             "root=${mmcroot} " \
>> -             "rootfstype=${mmcrootfstype}\0" \
>> +     "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
>> +     "mmcargs=setenv bootargs console=${console_mainline},${baudrate} root=${mmcroot}\0" \
>>       "loadbootscript="  \
>>               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
>>       "bootscript=echo Running bootscript from mmc ...; "     \
>>
>
> WARNING: line over 80 characters
> #37: FILE: include/configs/mx28evk.h:296:
> +       "mmcargs=setenv bootargs console=${console_mainline},${baudrate}
> root=${mmcroot}\0" \
>
> total: 0 errors, 1 warnings, 13 lines checked
>
> Can you fix it ?

Yes but I think it'd be more confusing for someone reading the code.
If you do want me to fix it, I do.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br