[U-Boot] [PATCH] arm/bootstage: Move the bootstage call after gd init

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Dec 27 11:22:03 CET 2012


On Thu, 27 Dec 2012 10:41:06 +0100, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:
> Hi Simon,
> 
> On Wed, 26 Dec 2012 12:39:32 -0800, Simon Glass <sjg at chromium.org>
> wrote:
> > Hi Vikram,
> > 
> > On Sun, Dec 23, 2012 at 3:27 AM, Vikram Narayanan <vikram186 at gmail.com> wrote:
> > > bootstage_mark_name calls timer_get_boot_us which inturn calls
> > > the arch timer. The arch timer uses the gd pointer to save the
> > > lastinc count. A call to bootstage_mark_name here results in a
> > > data abort as gd is uninitialized.
> > >
> > > Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
> > > Cc: Simon Glass <sjg at chromium.org>
> > > Cc: Wolfgang Denk <wd at denx.de>
> > > Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> > 
> > Acked-by: Simon Glass <sjg at chromium.org>
> > 
> > This bug will affect boards which don't have their own
> > timer_get_boot_us() function.
> > 
> > Albert, I think we should try to get this in as a bug fix in the
> > upcoming release.
> > 
> > Thanks for the fix Vikram.
> 
> Thanks Vikram and Simon; I'll pull this in today.

... actually, this will depend on whether my crt0 change gets in for
2013.01, as with this change, gd is already initialized when
entering board_init_f().

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list