[U-Boot] [PATCH 01/15] fdt: Use sed instead of cpp to pre-process the dtc

Simon Glass sjg at chromium.org
Fri Dec 28 15:55:52 CET 2012


Hi Stephen,

On Thu, Dec 27, 2012 at 4:03 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 12/26/2012 03:28 PM, Simon Glass wrote:
>> Include file support in dtc is still not available in common distributions
>> so we need to keep our preprocessing arrangement around for a little
>> longer.
>>
>> But # is commonly used in FDT files, so use sed instead of cpp for this
>> preprocessing.
>
> This sounds like the wrong approach to me. I'd suggest using what I
> proposed for the kernel:
>
>> cmd_dtc_cpp = $(CPP) $(cpp_flags) -D__DTS__ -x assembler-with-cpp -o $(dtc-tmp) $< ; \
>>         $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) $(dtc-tmp)
>
> The "-x assembler-with-cpp" is what solves the # problem IIRC.

I originally used CPP as an expedient means of converting the
ARCH_CPU_DTS symbol until we all have a dtc with include path support.

Are you saying that we want to actually use the CPP on tthe device
tree and (presumably) use U-Boot include files within the FDT?

Regards,
Simon


More information about the U-Boot mailing list