[U-Boot] [PATCH] ARMV7: Add support for TRATS board

Kim, Heungjun riverful.kim at samsung.com
Thu Jan 5 12:28:45 CET 2012


Hi Wolfgang Denk,

Thanks for the comments.

I'm preparing the modified version as you pointed out.
But I have one curious thing among your comments.

On 2012년 01월 05일 17:59, Wolfgang Denk wrote:
> Dear "HeungJun, Kim",
>
> In message<1325751248-23125-1-git-send-email-riverful.kim at samsung.com>  you wrote:
>> This patch adds support for Samsung TRATS board
>>
>> Signed-off-by: HeungJun, Kim<riverful.kim at samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park at samsung.com>
> ...
....
>> + */
>> +uart_asm_init:
> ...
>> +system_clock_init:
> ...
>> +system_power_init:
> ...
>
> What are the compelling reasons to write thes functionms in assembler,
> and not in C?
No. There is not specific reason. It's just to fit the convention with 
lowlevel_init.S file of any other previous boards based on Exynos4 SoC.
And it's true it's easy to check the changes between these boards. So, I 
thought there's not a big problem whether this is changed to be C or not.

I'm just curious the pros of using C rather than asm in this case.
Could you explain it?

Thank you.

Regards,
Heungjun Kim

>
> Best regards,
>
> Wolfgang Denk
>



More information about the U-Boot mailing list