[U-Boot] [PATCH] env: factor out the env_get_char_spec() function
Wolfgang Denk
wd at denx.de
Thu Jan 5 16:35:03 CET 2012
Dear Igor Grinberg,
In message <1324906390-26264-1-git-send-email-grinberg at compulab.co.il> you wrote:
> env_get_char_spec() function is duplicated across multiple environment
> files.
> Remove the duplication by providing a default implementation.
> Add "weak" declaration, so the default implementation can be overridden.
>
> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
> ---
> common/env_common.c | 7 +++++++
> common/env_flash.c | 5 -----
> common/env_mgdisk.c | 5 -----
> common/env_mmc.c | 5 -----
> common/env_nand.c | 5 -----
> common/env_nowhere.c | 5 -----
> common/env_nvram.c | 6 ++----
> common/env_onenand.c | 5 -----
> common/env_sf.c | 5 -----
> 9 files changed, 9 insertions(+), 39 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of trouble to go to
just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_
More information about the U-Boot
mailing list