[U-Boot] [PATCH 01/14] Add AES crypto library

Mike Frysinger vapier at gentoo.org
Sun Jan 8 10:09:11 CET 2012


On Sunday 08 January 2012 03:57:47 Marek Vasut wrote:
> > On Monday 26 December 2011 14:32:54 Simon Glass wrote:
> > > --- /dev/null
> > > +++ b/lib/aes.c
> > > 
> > > +static u8 sbox[256] = {
> > > +static u8 inv_sbox[256] = {
> > > +static u8 x2_sbox[256] = {
> > > +static u8 x3_sbox[256] = {
> > > +static u8 x_time_9[256] = {
> > > +static u8 x_time_b[256] = {
> > > +static u8 x_time_d[256] = {
> > > +static u8 x_time_e[256] = {
> > 
> > const
> > 
> > > +static void mix_sub_columns(u8 *state)
> > > +{
> > > ...
> > > +		 x3_sbox[state[2]] ^       sbox[state[7]];
> > 
> > looks bad whitespace after that ^
> > 
> > > +static u8 rcon[11] = {
> > 
> > const
> 
> We already have checkpatch in tools ... run it on the series.

i don't think checkpatch catches const
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120108/3250cc48/attachment.pgp>


More information about the U-Boot mailing list