[U-Boot] [PATCH 2/4] dfu: generic backend parts

[Andrzej Pietrasiewicz]

Hello Mike,

On Sunday, January 08, 2012 6:14 AM Mike Frysinger wrote:

> -----Original Message-----
> From: Mike Frysinger [mailto:vapier at gentoo.org]
> Sent: Sunday, January 08, 2012 6:14 AM
> To: u-boot at lists.denx.de
> Cc: Andrzej Pietrasiewicz; Kyungmin Park; Marek Szyprowski
> Subject: Re: [U-Boot] [PATCH 2/4] dfu: generic backend parts
> 

<...>

> 
> COBJS-$(CONFIG_XXX) += foo.o
> 

<...>

> 
> missing intro comment block
> 

<...>

> 
> there seems to be a lot of funcs in this file and others that have
> misplaced "inline" markings
>

<...>
 
> 
> API needs to be namespaced here with like "dfu_" prefixes
> 

<...>

> 
> file needs protection against multiple inclusion
>
 
<...>
 
> seems like you declare funcs here that aren't actually defined ...
> -mike

Thank you for your review. As far as I remember this patch series
was a "quick-and-dirty" attempt at splitting the implementation into
parts so that Stefan Shmidt could continue his work with his own
dfu backends.

However, Wolfgang Denk was not convinced about introducing dfu
support to u-boot the way it was proposed. Are there any new
circumstances?

Andrzej