[U-Boot] [PATCH 5/9] sandbox: sort header files in os.c

Simon Glass sjg at chromium.org
Mon Jan 9 23:17:48 CET 2012


Hi Mike,

On Sun, Jan 8, 2012 at 12:49 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 05 January 2012 22:54:53 Simon Glass wrote:
>> --- a/arch/sandbox/cpu/os.c
>> +++ b/arch/sandbox/cpu/os.c
>>
>> +#include <errno.h>
>>  #include <fcntl.h>
>> +#include <linux/types.h>
>>  #include <stdlib.h>
>>  #include <termios.h>
>> -#include <unistd.h>
>>  #include <time.h>
>> -#include <errno.h>
>> -#include <sys/types.h>
>> -#include <sys/stat.h>
>> +#include <unistd.h>
>>  #include <sys/mman.h>
>> -#include <linux/types.h>
>> +#include <sys/stat.h>
>> +#include <sys/types.h>
>
>
> the order should generally be:
>        - stuff in include/
>        - stuff in sys/
>        - stuff in linux/
>        - stuff in asm/
> each sub-region can be sorted, but i don't think we should go against the
> subdir rule

OK done, thanks.

Regards,
Simon

> -mike


More information about the U-Boot mailing list