[U-Boot] [PATCH] usb: add numeric keypad support to HID driver

[Vincent Palatin]

On Mon, Jan 9, 2012 at 15:13, Marek Vasut <marek.vasut at gmail.com> wrote:
>> +     /* Numeric keypad */
>> +     if ((scancode >= 0x54) && (scancode <= 0x67))
>> +             keycode = usb_kbd_num_keypad[scancode - 0x54];
>> +
>>       if (data->flags & USB_KBD_CTRL)
>>               keycode = scancode - 0x3;
>
> This is good, but what happens if you press "Ctrl + numpad_key" ? Check line 221
> in usb_kbd.c for what I mean.

As before the patch, it returns some random uppercase letters.
This is broken : IMO not only for those keys, but for all keys excepted A-Z.

-- 
Vincent