[U-Boot] [PATCH 13/15] New board support: Nokia RX-51 aka N900

[Pali Rohár]

On Tuesday 03 January 2012 09:05:17 Tom Rini wrote:
> On Sun, Dec 18, 2011 at 2:34 PM, Pali Rohár <pali.rohar at gmail.com> wrote:
> > This board definition results in a u-boot.bin which can be chainloaded
> > from NOLO in qemu or on a real N900. It does very little hardware config
> > because NOLO has already configured the board. Only needed is enabling
> > internal eMMC memory via twl4030 regulator which is not enabled by NOLO.
> 
> [snip]
> 
> > +/*
> > + * Routine: save_boot_params (called after reset from start.S)
> > + * Description: Save atag address and attached kernel address.
> > + *              Move u-boot to address CONFIG_SYS_TEXT_BASE
> > + */
> > +asm(
> > +"startaddr:\n"         /* address where should be u-boot after relocation
> > */
> Please put this into its own .S file so it's more readable, thanks.
> 

Ok. I will put it into board/nokia/rx51/rx51.S

> [snip]
> 
> > +/*
> > + * High Level Configuration Options
> > + */
> > +
> > +#define CONFIG_ARMV7                   /* This is an ARM V7 CPU core */
> 
> This isn't used.
> 
> > +#define CONFIG_L2_OFF                  /* kernel won't boot if l2 enabled
> > */
> This isn't correct for disabling L2 now and doesn't do anything.  So
> L2 is probably enabled :)

and #define CONFIG_SYS_L2CACHE_OFF is correct?

> 
> [snip]
> 
> > +/* DDR - I use Micron DDR */
> > +#define CONFIG_OMAP3_MICRON_DDR
> 
> No you don't :)  This can go away.
> 

ok, deleted.

> [snip]
> 
> > +#ifdef CONFIG_USE_IRQ
> > +#define CONFIG_STACKSIZE_IRQ           (4 << 10)       /* IRQ stack 4 KiB
> > */ +#define CONFIG_STACKSIZE_FIQ           (4 << 10)       /* FIQ stack 4
> > KiB */ +#endif
> 
> We just removed all of these from other config files.
> 

deleted too.

> > +/*-----------------------------------------------------------------------
> > + * Physical Memory Map
> > + */
> > +#define CONFIG_NR_DRAM_BANKS           2 /* CS1 may or may not be
> > populated */ +#define PHYS_SDRAM_1                   OMAP34XX_SDRC_CS0
> > +#define PHYS_SDRAM_2                   OMAP34XX_SDRC_CS1
> > +
> > +/* SDRAM Bank Allocation method */
> > +#define SDRC_R_B_C                     1
> 
> And I'm not sure if any of these are really needed now.
> 

When I deleted this code, I cannot compile U-Boot. Here is error message:
include/asm/u-boot.h:48:17: error: ‘CONFIG_NR_DRAM_BANKS’ undeclared here (not 
in a function)

So this code is needed.

> Thanks.

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120110/56576840/attachment.pgp>