[U-Boot] [PATCH v2 5/9] sandbox: sort header files in os.c

Simon Glass sjg at chromium.org
Wed Jan 11 00:52:17 CET 2012


Hi Mike,

On Tue, Jan 10, 2012 at 10:07 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 09 January 2012 17:25:15 Simon Glass wrote:
>> --- a/arch/sandbox/cpu/os.c
>> +++ b/arch/sandbox/cpu/os.c
>>
>> +#include <errno.h>
>>  #include <fcntl.h>
>> +#include <os.h>
>>  #include <stdlib.h>
>>  #include <termios.h>
>> -#include <unistd.h>
>>  #include <time.h>
>> -#include <errno.h>
>> -#include <sys/types.h>
>> -#include <sys/stat.h>
>> +#include <unistd.h>
>>  #include <sys/mman.h>
>> +#include <sys/stat.h>
>> +#include <sys/types.h>
>>  #include <linux/types.h>
>>
>> -#include <os.h>
>
> this is a u-boot header, so it should be last :)

Oh dear, I thought they were all U-Boot headers, but I think I see
what you mean.

v3 coming...

Regards,
Simon

>
> the rest look good now
> -mike


More information about the U-Boot mailing list