[U-Boot] [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO

[Liu Gang-B34182]

-----Original Message-----
From: Tabi Timur-B04825 
Sent: Wednesday, January 11, 2012 1:03 AM
To: Liu Gang-B34182
Cc: u-boot at lists.denx.de; Alexandre.Bounine at idt.com; Gala Kumar-B11780; Zang Roy-R61911; Xie Shaohui-B21989
Subject: Re: [U-Boot] [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO

On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang <Gang.Liu at freescale.com> wrote:
> When boot from SRIO, slave's ucode can be stored in master's memory 
> space, then slave can fetch the ucode image through SRIO interface.

What kind of ucode is this?  Fman or QE?
[Liu Gang-B34182] Right now the ucode is for Fman.

> +
> +       /* configure inbound window for slave's ucode */
> +       printf("SRIOBOOT - MASTER: Inbound window for slave's ucode; "
> +                       "Local = 0x%llx, Srio = 0x%llx, Size = 
> + 0x%x\n",
> +                       (u64)CONFIG_SRIOBOOT_SLAVE_UCODE_LAW_PHYS,
> +                       (u64)CONFIG_SRIOBOOT_SLAVE_UCODE_SRIO_PHYS,
> +                       CONFIG_SRIOBOOT_SLAVE_UCODE_SIZE);
> +       out_be32((u32)&srio->riwtar3 + CONFIG_SRIOBOOT_MASTER_PORT * 
> + 0x200,

These should be "(void *)" instead of "(u32)".
[Liu Gang-B34182] Thanks very much!

--
Timur Tabi
Linux kernel developer at Freescale