[U-Boot] [PATCH 2/8] powerpc/env: Correct the compilation errors when defined CONFIG_ENV_IS_NOWHERE

[Liu Gang-B34182]

Hi, Timur,
Thanks for your comments.
Please find my replies inline.

Best Regards,

Liu Gang

-----Original Message-----
From: Tabi Timur-B04825 
Sent: Wednesday, January 11, 2012 12:48 AM
To: Liu Gang-B34182
Cc: u-boot at lists.denx.de; Alexandre.Bounine at idt.com; Gala Kumar-B11780; Zang Roy-R61911
Subject: Re: [U-Boot] [PATCH 2/8] powerpc/env: Correct the compilation errors when defined CONFIG_ENV_IS_NOWHERE

On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang <Gang.Liu at freescale.com> wrote:
>
> There will be a confict if defined CONFIG_ENV_IS_NOWHERE and 
> CONFIG_ENV_IS_IN_FLASH.

This doesn't make any sense.  How can the environment be nowhere *and* also in flash, at the same time?

[Liu Gang-B34182] The environment cannot be nowhere *and* also in flash at the same time! So we should not
re-defined CONFIG_ENV_IS_IN_FLASH if the CONFIG_ENV_IS_NOWHERE has been defined. But the code will still define
CONFIG_ENV_IS_IN_FLASH if the CONFIG_ENV_IS_NOWHERE has been defined. This will cause a compilation error
described in this patch.

--
Timur Tabi
Linux kernel developer at Freescale