[U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO

[Liu Gang-B34182]

Thanks very much!
I'll update the patch based on your comments.

Best Regards,

Liu Gang

-----Original Message-----
From: Tabi Timur-B04825 
Sent: Wednesday, January 11, 2012 11:00 AM
To: Liu Gang-B34182
Cc: 'u-boot at lists.denx.de'; 'Alexandre.Bounine at idt.com'; Gala Kumar-B11780; Zang Roy-R61911; Xie Shaohui-B21989
Subject: Re: [U-Boot] [PATCH 5/8] powerpc/boot: Slave module for boot from SRIO

Liu Gang-B34182 wrote:
> Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented?  And where is the code that uses it?
> [Liu Gang-B34182] Sorry I documented this definition in "[PATCH 6/8] 
> powerpc/boot: Slave uploads ucode when boot from SRIO",

You need to update the README.  That's where all the other CONFIG_SYS_QE_FMAN_FW_xxx macros are documented.

> I'll add descriptions about this definition in PATCH 5/8.
> The function "fm_init_common" in the file drivers/net/fm/fm.c uses the CONFIG_SYS_QE_FMAN_FW_IN_REMOTE.

The code which adds CONFIG_SYS_QE_FMAN_FW_IN_REMOTE support should be its own patch.  And the patch summary should say "CONFIG_SYS_QE_FMAN_FW_IN_REMOTE".

--
Timur Tabi
Linux kernel developer at Freescale