[U-Boot] [PATCH 1/8] powerpc/srio: Correct the register defined errors in the struct ccsr_rio_t

[Wolfgang Denk]

Dear Liu Gang,

In message <1326195751-20729-1-git-send-email-Gang.Liu at freescale.com> you wrote:
> Many registers were not defined in the struct ccsr_rio_t in the file
> arch/powerpc/include/asm/immap_85xx.h. For example it lacks registers
> from offset 0xc0600 to 0xd0160. Accordingly, some register's offset
> need to be modified in the struct.

Your Subject line is way too long, make it shorter.

Also, it is not correct - the registers may be missing for some
extensions you will add, but that has not been an error so foar, so
this patch is an extension, but not a correction.

>  /* RapidIO Registers */
>  typedef struct ccsr_rio {
> -	u32	didcar;		/* Device Identity Capability */
> -	u32	dicar;		/* Device Information Capability */
> -	u32	aidcar;		/* Assembly Identity Capability */
> -	u32	aicar;		/* Assembly Information Capability */
> -	u32	pefcar;		/* Processing Element Features Capability */
> -	u32	spicar;		/* Switch Port Information Capability */
> -	u32	socar;		/* Source Operations Capability */
> -	u32	docar;		/* Destination Operations Capability */
> +	u32	didcar; /* 0xc0000 - Device Identity CAR */
> +	u32	dicar; /* 0xc0004 - Device Information CAR */
> +	u32	aidcar; /* 0xc0008 - Assembly Identity CAR */
> +	u32	aicar; /* 0xc000c - Assembly Information CAR */
> +	u32	pefcar; /* 0xc0010 - Processing Element Features CAR */
> +	u32	spicar; /* 0xc0014 - Switch Port Information CAR */
> +	u32	socar; /* 0xc0018 - Source Operations CAR */
> +	u32	docar; /* 0xc001c - Destination Operations CAR */

NAK.  We don't include offsets into the header files.  Please keep
this consistent with the rest of this file, and with other, similar
files. 

Restrict your patch on adding any new fields, and foillow the exiting
style.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  What's a light-year?
A:  One-third less calories than a regular year.