[U-Boot] [PATCH 6/8] powerpc/boot: Slave uploads ucode when boot from SRIO
Liu Gang
Gang.Liu at freescale.com
Fri Jan 13 08:04:30 CET 2012
Dear Wolfgang,
On Wed, 2012-01-11 at 08:23 +0100, Wolfgang Denk wrote:
> > +#ifdef CONFIG_SRIOBOOT_SLAVE
> > + /*
> > + * *I*G - SRIOBOOT-SLAVE. 1M space from 0xffe00000 for fetching ucode
> > + * and ENV from master
> > + */
>
> What is this "*I*G - " doing here?
This means that the TLB entry will be set with attribute "MAS2_I"
and "MAS2_G".
This follows the existing style of the file.
> > +/*
> > + *for slave UCODE instored in master memory space,
> > + *PHYS must be aligned based on the SIZE
> > + */
>
> Please add a space between the '*' anf the text.
>
> Please fix globally.
Thanks, will add.
Best Regards,
Liu Gang
More information about the U-Boot
mailing list