[U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back

Wolfgang Denk wd at denx.de
Fri Jan 13 20:19:08 CET 2012


Dear Eric Miao,

In message <1313559224-4627-1-git-send-email-eric.miao at linaro.org> you wrote:
> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it
> fails, fall back to use dev->enetaddr, which could be filled up by
> the ethernet device driver.
> 
> Actually, this is the original behavior, and was later changed by
> commit 48506a2cde2458fa1f8c5993afc98e5a4617e1d3.

I'm not going to pull that patch.

Please explain which actual problem you're trying to fix.

Also, fix the commit ID - the one you list above does not exist in
mainline.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."


More information about the U-Boot mailing list