[U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

Wolfgang Denk wd at denx.de
Fri Jan 13 22:25:32 CET 2012


Dear Simon Glass,

In message <CAPnjgZ1=1+xjHoAbJd4WETjC6Bj+6NPgGsXbStoGadieznF1=Q at mail.gmail.com> you wrote:
> 
> > run_command2() in "common/main.c" (now renamed into run_command() will
> > return 0 or 1 when used with the hush shell; it will never return < 0.
> 
> Thanks for looking at this. I will see what I can figure out.

I think there is some pre-existing inconsistency here, which pops up
when you try to unify the code.

I think we should implement standard shell handline here: commands
return EXIT_SUCCESS or EXIT_FAILURE.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not "Eureka!" (I found it!) but "That's funny ..."
                                                      -- Isaac Asimov


More information about the U-Boot mailing list