[U-Boot] [PATCH] omap3: board.c - Fix compile warnings

[Tom Rini]

On Sat, Jan 14, 2012 at 4:40 PM, Pali Rohár <pali.rohar at gmail.com> wrote:
> On Saturday 14 January 2012 21:12:00 Marek Vasut wrote:
>> >  * This patch fix compile warnings when CONFIG_SYS_L2CACHE_OFF is enabled
>> >
>> >    board.c:48:13: warning: ‘omap3_invalidate_l2_cache_secure’ declared
>> >
>> > ‘static’ but never defined board.c:373:13: warning: ‘omap3_update_aux_cr’
>> > defined but not used
>> >
>> > Signed-off-by: Pali Rohár <pali.rohar at gmail.com>
>> > ---
>> >
>> >  arch/arm/cpu/armv7/omap3/board.c |    5 +++++
>> >  1 files changed, 5 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/cpu/armv7/omap3/board.c
>> > b/arch/arm/cpu/armv7/omap3/board.c index 1f33c63..52514ae 100644
>> > --- a/arch/arm/cpu/armv7/omap3/board.c
>> > +++ b/arch/arm/cpu/armv7/omap3/board.c
>> > @@ -45,7 +45,10 @@
>> >
>> >  /* Declarations */
>> >  extern omap3_sysinfo sysinfo;
>> >  static void omap3_setup_aux_cr(void);
>> >
>> > +
>> > +#ifndef CONFIG_SYS_L2CACHE_OFF
>> >
>> >  static void omap3_invalidate_l2_cache_secure(void);
>> >
>> > +#endif
>>
>> This is due to the ordering, right ? Now, split this into two patches,
>> because you're actually doing two unrelated things.
>
> No, function omap3_invalidate_l2_cache_secure is defined in block #ifndef
> CONFIG_SYS_L2CACHE_OFF. So declaration should be in #ifndef too.

Right, but if we move the function to be just before it's used, inside
the existing ifndef block we can remove the prototype instead.

-- 
Tom