[U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

Wolfgang Denk wd at denx.de
Mon Jan 16 09:19:34 CET 2012


Dear Stephan Linz,

In message <1326656467.18981.225.camel at keto> you wrote:
>
> OK, I'll try to change the buffer handling as soon as possible in one of
> the next optimization stages of this driver. Looks interesting and
> important to me ...
...
> The alignment is essential for the LL TEMAC driver, especially the 32
> byte alignment. I look to continue to optimize this part after the patch
> has been added.

No, please do it now.  I will not pull the current patch.

> > or do it now and re-submit a v2 ...
> 
> I have already done. Patch is coming up ... :-)

No, you misunderstant.  You submitted an incremental, separate patch.

But we don't want to add code that is known to have problems /
shortcomings now and fix / improve it 5 minutes later.  We let the
patch ripe and add it only when we consider it ready.

So please do not defer weorkign on the review comments.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Look! There! Evil!.. pure and simple, total  evil  from  the  Eighth
Dimension!"                                         - Buckaroo Banzai


More information about the U-Boot mailing list