[U-Boot] [PATCH] arm, davinci: cam_enc_4xx board updates

Heiko Schocher hs at denx.de
Tue Jan 17 07:29:21 CET 2012


Hello tom,

Tom Rini wrote:
> On Sun, Jan 15, 2012 at 12:59 AM, Heiko Schocher <hs at denx.de> wrote:
> 
> [snip]
>> diff --git a/board/ait/cam_enc_4xx/ublimage.cfg b/board/ait/cam_enc_4xx/ublimage.cfg
>> index 95182ca..2374c72 100644
>> --- a/board/ait/cam_enc_4xx/ublimage.cfg
>> +++ b/board/ait/cam_enc_4xx/ublimage.cfg
>> @@ -39,7 +39,7 @@ PAGES 6
>>
>>  # Block number where user bootloader is present
>>  # RBL starts always with block 1
>> -START_BLOCK    5
>> +START_BLOCK    0
> 
> Is the comment here still correct and fully explaining things?  It's a
> little puzzling when I read it, but I don't have a good handle on the
> UBL stuff yet.

The line "# RBL starts always with block 1" is missleading. I delete
this line!

> And aside from expecting a rework of some of this to match Wolfgang's
> comments about FIT images, the rest seems fine to me.

Thanks for your review! I send an update which handles Wolfgangs FIT
comment today.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list