[U-Boot] [PATCH v2 2/2] fdt: Add tests for fdtdec

Simon Glass sjg at chromium.org
Tue Jan 17 19:17:44 CET 2012


Hi Stephen,

On Fri, Jan 13, 2012 at 1:49 PM, Stephen Warren <swarren at nvidia.com> wrote:
> On 01/11/2012 04:08 PM, Simon Glass wrote:
>> The fdtdec_find_aliases_for_id() function is complicated enough that
>> it really should have some tests. This does not necessarily need to be
>> committed to U-Boot, but it might be useful.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
>> +static int run_test(const char *aliases, const char *nodes, const char *expect)
> ...
>> +     va_list ptr;
> ...
>> +     va_end(ptr);
>
> ptr doesn't seem to be used, and this isn't a varargs function.

Yes, it's a hangover from my previous non-string implementation. I
will send a new series as there are a couple of changes.

Regards,
Simon

>
> Otherwise,
>
> Acked-by: Stephen Warren <swarren at nvidia.com>
>
> --
> nvpublic


More information about the U-Boot mailing list