[U-Boot] [PATCH] common, menu: do not trigger timeout again, if a line is read

Heiko Schocher hs at denx.de
Wed Jan 18 07:13:19 CET 2012


Hello Mike,

Mike Frysinger wrote:
> On Tuesday 17 January 2012 03:24:29 Heiko Schocher wrote:
>> --- a/common/menu.c
>> +++ b/common/menu.c
>>  			choice_item = menu_item_by_key(m, cbuf);
>>
>> -			if (!choice_item)
>> +			if (!choice_item) {
>>  				printf("%s not found\n", cbuf);
>> +				m->timeout = 0;
>> +			}
>>  		} else {
>>  			puts("^C\n");
>>  			return -EINTR;
> 
> the summary says "do not timeout again if a line is read", but this C code 
> seems like "do not timeout again if an item was selected but not found".  but 
> maybe i'm reading the menu code incorrectly ?

No, you are reading C code right, fix this, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list