[U-Boot] [PATCH 2/6] mx6q: Add support for ECSPI through mxc_spi driver

[Stefano Babic]

On 18/01/2012 17:08, Marek Vasut wrote:

> Ok guys, I see ... Stefano, you're ok with putting the reg structures into these 
> header files?

The reg structures are already into these header files - the patch moves
only the bit meaning inside the imx-regs.h files. We can discuss if we
should move them again into the driver, making the decision on which
structure to be used not on a SOC level (#ifdef CONFIG_MXxx), but on
basis of the controller type (CSPI or ECSPI).

This makes sense if we run (we had until now no use case with the
currently supported boards) a MX5 board using a CSPI instead of a ECSPI.
In this case, we should also transform MXC_CSPI / MXC_ECSPI in a CONFIG_
define to be put in the board configuration file.

However, as usual in u-boot, dead code or code that has no use case and
cannot be tested is not allowed. Until we have not such a board (MX5
board requiring CSPI instead of ECSPI), we should avoid to introduce not
tested code and let those changes for a next patch.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================