[U-Boot] [PATCH V3 2/2] tt01: add MMC support

[Helmut Raiger]

On 01/18/2012 01:37 PM, Stefano Babic wrote:
> Hi Helmut,
>
>> +#ifdef CONFIG_CONSOLE_EXTRA_INFO
>> +void video_get_info_str(int line_number, char *info)
> This has nothing with MCC. Please extend your commit message to explain
> you are also adding this feature.
I simply mixed in a different branch, which was not the intention, sorry 
for the noise, I'll resend.

>> +{
>> +	u32 srev = get_cpu_rev();
>> +
>> +	switch (line_number) {
>> +	case 2:
>> +		sprintf(info, " CPU  : Freescale i.MX31 rev %d.%d%s at %d MHz",
>> +				(srev&  0xF0)>>  4, (srev&  0x0F),
>> +				((srev&  0x8000) ? " unknown" : ""),
>> +				mxc_get_clock(MXC_ARM_CLK) / 1000000);
> I know it is only one line, but it is not related to your board because
> it is really print_cpuinfo() into a buffer. So this cpu part should be
> moved into the SOC place (arch/arm/cpu/arm1136/mx31/generic.c).
>
> However, which is the real reason to do that ? I have supposed that
> setting video as stdout it is enough to redirect all output to the LCD,
> and then the usual print_cpuinfo() works, without adding / duplicating
> function that already use printf() for the output.
>
> I do not see a lot of boards implementing video_get_info_str(), and I
> understand that it is a way to customize the output. However, is it the
> correct way ? Does print_cpuinfo() not work if redirect to the video ? I
> have added Anatolji (video maintainer in CC) to get his opinion.
>
> Best regards,
> Stefano Babic
>
Actually the above is only a glitch, the output sits there since more 
than a year (probably adjusted at some point).
I just didn't realize that print_cpuinfo does the same.
I'll be contributing the video stuff in one of the next patches for tt01 
and fix it then, so thanks for your review, even though I'll remove it 
from this patch.

Helmut



--
Scanned by MailScanner.