[U-Boot] [PATCH 1/3] i2c: add i2c_core and prepare for new multibus support

Simon Glass sjg at chromium.org
Thu Jan 19 19:10:03 CET 2012


Hi Wolfgang,

On Thu, Jan 19, 2012 at 3:20 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Simon Glass,
>
> In message <CAPnjgZ1RoyguaAScOQiw8PoQkzVp5rim7KJ6zzHLNPwuBYK48Q at mail.gmail.com> you wrote:
>>
>> Perhaps reword this slightly. U-Boot can have knowledge of a current
>> adaptor, mux settings and so on, and use this internally within the
>> i2c layer to optimise performance and redundant i2c traffic. But the
>> pain is when the concept of a 'current adaptor' is exposed outside the
>> i2c layer.
>
> As mentioned before, this is what we currently have as "device model"
> in U-Boot - not only I2C: we have the same "current device" concept
> with IDE, USB, ...
>
> It makes no sense trying to change it here; it would only cause even
> more incompatibilities.  If you want to fix that, then help working on
> the new driver model.  Marek is planning for this.

Yes of course, sorry for not replying earlier, but I completely agree.
Heiko's patch here fits with the "current device" model. I was talking
about the way I hope it will be in the future. I can help with new
driver model also but I would like to get the rationalisation of code
duplication (relocation, board init) to bed first.

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Good morning. This is the telephone company. Due  to  repairs,  we're
> giving  you  advance notice that your service will be cut off indefi-
> nitely at ten o'clock. That's two minutes from now.


More information about the U-Boot mailing list