[U-Boot] [PATCH v4 17/20] tegra: usb: Add USB support to nvidia boards

Simon Glass sjg at chromium.org
Fri Jan 20 00:53:10 CET 2012


Hi Stephen,

On Wed, Jan 18, 2012 at 4:30 PM, Stephen Warren <swarren at nvidia.com> wrote:
> On 01/11/2012 09:33 PM, Simon Glass wrote:
>> This adds basic USB support for port 0. The other port is not supported
>> yet.
>
>> diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
>
>> +#ifdef CONFIG_USB_EHCI_TEGRA
>> +     /* For USB GPIO PD0. for now, since we have no pinmux in fdt */
>> +     pinmux_tristate_disable(PINGRP_SLXK);
>
> Can we ifdef this so it only happens on Seaboard? Who knows what other
> boards use that pin group for. Unfortunately, I checked and this really
> does appear required for Seaboard, since there's no pull on the
> USB1_VBUS_EN GPIO, so Tegra must drive it.

Yes will do. The pinmux is the hole in our fdt armour at present as you know.

Regards,
Simon

>
> --
> nvpublic


More information about the U-Boot mailing list