[U-Boot] [PATCH 01/14] arm, omap3: Define save_boot_params in lowlevel_init.S for SPL only
Tom Rini
tom.rini at gmail.com
Wed Jan 25 19:47:41 CET 2012
On Tue, Jan 24, 2012 at 7:27 AM, Pali Rohár <pali.rohar at gmail.com> wrote:
> * Hide function save_boot_params if CONFIG_SPL_BUILD is not defined (function do nothing)
This is fine.
> * Same behaviour as in file arch/arm/cpu/armv7/omap4/lowlevel_init.S
This isn't quite right. OMAP4/5 and AM33XX can re-use the same code
here to determine boot device/mode but it's not the same as 'OMAP3.'
> * This allow to implement board specified function save_boot_params in board code
This is fine.
> Signed-off-by: Pali Rohár <pali.rohar at gmail.com>
So I will apply this, but modify the commit message slightly.
--
Tom
More information about the U-Boot
mailing list