[U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver

[Vasily Khoruzhick]

2012/1/25 Marek Vasut <marek.vasut at gmail.com>:
>> From: Marek Vasut <marek.vasut at gmail.com>
>>
>> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
>> Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
>> [vasily: adapted Marek's old version for newer u-boot,
>>          fixed multiple keypresses handling]
>
> Fine ... albert, can you comment on it?
>
> Vasily, do you think this code is good? I want an honest answer!

Well, it's overcomplicated due to missing _generic_ keyboard support in u-boot.
It's possible to separate buffer handling, layout management into some
"keyboard-core",
so keyboard driver provides only key press/release events to core and
then core decides
what to do if we have multiple keys pressed, if modifier is pressed, etc, etc...

Anyway, for me this code is easy to understand, but it's for now. So
if you want _really_ honest answer -- wait for few weeks
so I can re-review it with fresh view.

Regards
Vasily