[U-Boot] [PATCH 1/3] USB: Armada100: Add UTMI PHY interface driver

[Ajay Bhargav]

----- "Prafulla Wadaskar" <prafulla at marvell.com> wrote:

> > +
> > +/* MPMU Clocks */
> > +#define MPMU_EN_ALL_CLKS        0x1EFFFF
> 
> Turning on all clocks is not logical to enable this support, only
> relevant clock necessary for this components SHOULD BE enabled.
> 
> Enabling clocks for unused peripherals/components may result in
> unnecessarily extra power consumption
> 
> Otherwise ack for rest of the patch
> 
> Regards..
> Prafulla . . .
> 
I followed programming guidlines as per Armada_16x software manual.
section: 20.4.3.1
snip of pseudo code from Programming guidlines section:
[...snip...]
print "******main PMU turn on all clocks\n"
set val *(unsigned long *)PMUM_ACGR=0x001EFFFF
print "******PMUap USBCLK Reset Control\n"
set val *(unsigned long *)PMUA_USB_CLK_RES_CTRL=0x1B
print "******UTMI ID\n"
eval /hex *(unsigned long *)UTMI_REVISION
[...snip...]

There is nothing mentioned in specific which clock is used/required by USB host controller.

Regards,
Ajay Bhargav