[U-Boot] [PATCH 2/6] microblaze: Enable several ethernet driver compilation

Wolfgang Denk wd at denx.de
Sun Jan 29 00:27:08 CET 2012


Dear Stephan Linz,

In message <1327740947.3638.16.camel at keto> you wrote:
> 
> > >  #define	CONFIG_ETHADDR		00:E0:0C:00:00:FD
> > > +#define	CONFIG_ETH1ADDR		00:E0:0C:00:00:FC
> > 
> > err, i think these need to get dropped.  boards should not be hardcoding mac 
> > addresses in their configs.
> 
> OK, I think so too. I can left at least one MAC address as it was in the
> original board configuration. I think we need this for a rapid system
> startup without a default configuration in ROM. IMHO there are many many
> boards that are going this way ...

Please drop it.  As Mike pointed out, it is not acceptable for
mainline code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What was sliced bread the greatest thing since?


More information about the U-Boot mailing list