[U-Boot] [PATCH] tools/mkenvimage.c: fix basename(3) usage

Wolfgang Denk wd at denx.de
Mon Jul 2 20:22:02 CEST 2012


Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message <1340863319-63074-1-git-send-email-andreas.devel at googlemail.com> you wrote:
> Use the POSIX variant of basename due to BSD systems (e.g. OS X) do not provide
> GNU version of basename(3). It is save to use the POSIX variant here cause we do
> never use argv[0] later on which may be modified by the basename(3) POSIX
> variant.
> On systems providing GNU variant the GNU variant should be used since string.h
> is included before libgen.h. Therefore let the _GNU_SOURCE as is.
> 
> This patch fixes following warning (on OS X):
> ---8<---
> mkenvimage.c: In function ‘main’:
> mkenvimage.c:105: warning: implicit declaration of function ‘basename’
> mkenvimage.c:105: warning: assignment makes pointer from integer without a cast
> --->8---
> 
> Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> cc: Keith Mok <ek9852 at gmail.com>
> ---
> This was sent by Keith Mok before. Read
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/126003
> 
>  tools/mkenvimage.c | 1 +
>  1 Datei geändert, 1 Zeile hinzugefügt(+)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Neckties strangle clear thinking.                       -- Lin Yutang


More information about the U-Boot mailing list