[U-Boot] [PATCH 2/2] EXYNOS: mmc: support DesignWare Controller for Samsung-SoC

[Jaehoon Chung]

Hi,

On 07/03/2012 02:39 PM, Rajeshwari Birje wrote:

> Hi Jaehoon Chung,
> 
> 
> On Tue, Jul 3, 2012 at 10:27 AM, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>> Support DesignWare MMC Controller for Samsung Specific.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> Signed-off-by: Rajeshawari Shinde <rajeshwari.s at samsung.com>
>> ---
>>  arch/arm/include/asm/arch-exynos/dwmmc.h |   36 ++++++++++++++++++
>>  drivers/mmc/exynos_dw_mmc.c              |   60 ++++++++++++++++++++++++++++++
>>  2 files changed, 96 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/include/asm/arch-exynos/dwmmc.h
>>  create mode 100644 drivers/mmc/exynos_dw_mmc.c
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/dwmmc.h b/arch/arm/include/asm/arch-exynos/dwmmc.h
>> new file mode 100644
>> index 0000000..2e4354d
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-exynos/dwmmc.h
>> @@ -0,0 +1,36 @@
>> +/*
>> + * (C) Copyright 2012 SAMSUNG Electronics
>> + * Jaehoon Chung <jh80.chung at samsung.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>> + *
>> + */
>> +
>> +#define DWMCI_CLKSEL           0x09C
>> +#define DWMCI_SHIFT_0          0x0
>> +#define DWMCI_SHIFT_1          0x1
>> +#define DWMCI_SHIFT_2          0x2
>> +#define DWMCI_SHIFT_3          0x3
>> +#define DWMCI_SET_SAMPLE_CLK(x)        (x)
>> +#define DWMCI_SET_DRV_CLK(x)   ((x) << 16)
>> +#define DWMCI_SET_DIV_RATIO(x) ((x) << 24)
>> +
>> +int exynos_dwmci_init(u32 regbase, u32 quirks, int bus_width, int index);
>> +
>> +static inline unsigned int exynos_dwmmc_init(int index, int bus_width)
>> +{
>> +       unsigned int base = samsung_get_base_mmc() + (0x10000 * index);
>> +       return exynos_dwmci_init(base, 50000000, 400000, index);
> We donot use bus_width here ?

It's missing.

>> +}
>> diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c
>> new file mode 100644
>> index 0000000..e9b0e1d
>> --- /dev/null
>> +++ b/drivers/mmc/exynos_dw_mmc.c
>> @@ -0,0 +1,60 @@
>> +/*
>> + * (C) Copyright 2012 SAMSUNG Electronics
>> + * Jaehoon Chung <jh80.chung at samsung.com>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,  MA 02111-1307 USA
>> + *
>> + */
>> +
>> +#include <common.h>
>> +#include <malloc.h>
>> +#include <dwmmc.h>
>> +#include <asm/arch/dwmmc.h>
>> +#include <asm/arch/clk.h>
>> +
>> +static char *EXYNOS_NAME = "EXYNOS DWMMC";
>> +
>> +static void exynos_dwmci_clksel(struct dwmci_host *host)
>> +{
>> +       u32 val;
>> +       val = DWMCI_SET_SAMPLE_CLK(DWMCI_SHIFT_0) |
>> +               DWMCI_SET_DRV_CLK(DWMCI_SHIFT_0) | DWMCI_SET_DIV_RATIO(0);
>> +
>> +       dwmci_writel(host, DWMCI_CLKSEL, val);
>> +}
>> +
>> +int exynos_dwmci_init(u32 regbase, u32 quirks, int bus_width, int index)
>> +{
>> +       struct dwmci_host *host = NULL;
>> +       host = (struct dwmci_host *)malloc(sizeof(struct dwmci_host));
>> +       if (!host) {
>> +               printf("dwmci_host malloc fail!\n");
>> +               return 1;
>> +       }
>> +
>> +       host->name = EXYNOS_NAME;
>> +       host->ioaddr = (void *)regbase;
>> +       host->quirks = quirks;
>> +       host->buswidth = bus_width;
>> +       host->fifoth_val = 0x20100010;
> Can this hard coding be removed?

Sure, we can remove this, then should be calculated with register's value at dw_mmc.c.
But we have two approaches..
1) Use the register value.
2) Set the fifoth_Val.
If you want to remove, don't mind..but i didn't ensure to work well. 

>> +       host->clksel = exynos_dwmci_clksel;
>> +       host->dev_index = index;
>> +       host->get_mmc_clk = get_mmc_clk;
> Can this be just mmc_clk, just a suggestion.

Sure..i will change the host->mmc_clk.

>> +
>> +       add_dwmci(host, 52000000, 400000, index);
>> +
>> +       return 0;
>> +}
>> +
>> --
>> 1.7.4.1
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>