[U-Boot] arm, kirkwood: KWGBE_PORT_SERIAL_CONTROL1_REG define correct?

Heiko Schocher hs at denx.de
Tue Jul 3 11:11:19 CEST 2012


Hello Prafulla,

I see in current mainline code:

arch/arm/include/asm/arch-kirkwood/cpu.h

35 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)      \
36                 ((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)

with results in:

if _x = 0 KW_EGIGA1_BASE and if _x = 1 KW_EGIGA0_BASE
         ^         ^                  ^         ^

is selected ... is this correct? I read _x as port and so this define
swaps the base addresses, or do I miss something?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list