[U-Boot] [PATCH] ext2fs: fix warning: 'blocknxt' may be used uninitialized

[Andreas Bießmann]

Dear Kim Philips,

On 03.07.12 18:05, Kim Phillips wrote:
> ext2fs.c: In function 'ext2fs_read_file':
> ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this function [-Wuninitialized]
> 
> Cc: Jason Cooper <u-boot at lakedaemon.net>
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
> is this right?
> 
>  fs/ext2/ext2fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c
> index f1fce48..c6c950e 100644
> --- a/fs/ext2/ext2fs.c
> +++ b/fs/ext2/ext2fs.c
> @@ -440,7 +440,7 @@ int ext2fs_read_file
>  		/* grab middle blocks in one go */
>  		if (i != pos / blocksize && i != blockcnt - 1 && blockcnt > 3) {
>  			int oldblk = blknr;
> -			int blocknxt;
> +			int blocknxt = 0;
>  			while (i < blockcnt - 1) {
>  				blocknxt = ext2fs_read_block(node, i + 1);
>  				if (blocknxt == (oldblk + 1)) {
> 

there are two other solutions. I dunno which should we use but Thierry
Reding suggested another working one which I think its cleaner. Please
read http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043

Best regards

Andreas Bießmann