[U-Boot] [PATCH v2] arm: cm4008, cm41xx: use common cfi_flash support

[Andreas Bießmann]

Dear Yann Vernier,

a simple small change request.

On 05.07.2012 15:11, Yann Vernier wrote:
> This change allows use of other flash chips than the two supported by
> the cm4008 flash.c. Tested with Micrel KSZ8695X demo board.
> ---
> Changes for v2:
>    - Update cm41xx also
>    - Remove unused board specific flash code
> 
> Signed-off-by: Yann Vernier <yann.vernier at orsoc.se>
> ---
>  board/cm4008/Makefile    |    2 +-
>  board/cm4008/flash.c     |  410 ----------------------------------------------
>  board/cm41xx/Makefile    |    2 +-
>  board/cm41xx/flash.c     |  410 ----------------------------------------------
>  include/configs/cm4008.h |    4 +
>  include/configs/cm41xx.h |    4 +
>  6 files changed, 10 insertions(+), 822 deletions(-)
>  delete mode 100644 board/cm4008/flash.c
>  delete mode 100644 board/cm41xx/flash.c
> 

<snip>

> diff --git a/include/configs/cm4008.h b/include/configs/cm4008.h
> index 58b0f4b..18b37d7 100644
> --- a/include/configs/cm4008.h
> +++ b/include/configs/cm4008.h
> @@ -119,6 +119,10 @@
>  #define PHYS_FLASH_SECT_SIZE    0x00020000 /* 128 KB sectors (x1) */
>  #define CONFIG_SYS_FLASH_BASE		PHYS_FLASH_1
>  
> +#define CONFIG_SYS_FLASH_CFI
> +#define CONFIG_FLASH_CFI_DRIVER		1

Do not define to 1 where it is not required, just define.

> +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_8BIT
> +
>  /*-----------------------------------------------------------------------
>   * FLASH and environment organization
>   */
> diff --git a/include/configs/cm41xx.h b/include/configs/cm41xx.h
> index d29040c..3f46b12 100644
> --- a/include/configs/cm41xx.h
> +++ b/include/configs/cm41xx.h
> @@ -119,6 +119,10 @@
>  #define PHYS_FLASH_SECT_SIZE    0x00020000 /* 128 KB sectors (x1) */
>  #define CONFIG_SYS_FLASH_BASE		PHYS_FLASH_1
>  
> +#define CONFIG_SYS_FLASH_CFI
> +#define CONFIG_FLASH_CFI_DRIVER		1

same here

> +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_8BIT
> +
>  /*-----------------------------------------------------------------------
>   * FLASH and environment organization
>   */
> 

Best regards

Andreas Bießmann